Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to docker/docker 26.1.4 #3553

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Revert to docker/docker 26.1.4 #3553

merged 1 commit into from
Jun 28, 2024

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Jun 24, 2024

27.0.0 was withdrawn, see moby/moby#47980

cadvisor can’t currently be built except on systems that have 27.0.0 in their cache. The tag was created by mistake instead of an RC tag.

27.0.0 was withdrawn, see moby/moby#47980

Signed-off-by: Stephen Kitt <[email protected]>
@k8s-ci-robot
Copy link
Collaborator

Hi @skitt. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skitt
Copy link
Contributor Author

skitt commented Jun 24, 2024

/cc @dims

@dims
Copy link
Collaborator

dims commented Jun 24, 2024

/approve
/lgtm

@skitt
Copy link
Contributor Author

skitt commented Jun 24, 2024

/cc @iwankgb @bobbypage

@dims
Copy link
Collaborator

dims commented Jun 24, 2024

@skitt waiting for the pull-cadvisor-e2e to finish.

@skitt
Copy link
Contributor Author

skitt commented Jun 24, 2024

Ah, right, sorry — I didn’t realise it was running (GH just shows me “expected”).

@dims
Copy link
Collaborator

dims commented Jun 24, 2024

/test pull-cadvisor-e2e

@dims
Copy link
Collaborator

dims commented Jun 24, 2024

weird that i had to force it to run...

@skitt
Copy link
Contributor Author

skitt commented Jun 24, 2024

/test pull-cadvisor-e2e

@k8s-ci-robot
Copy link
Collaborator

@skitt: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-cadvisor-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 28, 2024

/ok-to-test

@iwankgb iwankgb merged commit 7ea3a90 into google:master Jun 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants