Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade golang to 1.22.4 and bump up dep #20662

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jun 25, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw requested a review from a team as a code owner June 25, 2024 10:03
@zyyw zyyw assigned stonezdj and unassigned Vad1mo Jun 25, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.86%. Comparing base (64e4c85) to head (bcfd829).
Report is 2 commits behind head on release-2.9.0.

Current head bcfd829 differs from pull request most recent head ffc711f

Please upload reports for the commit ffc711f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #20662      +/-   ##
=================================================
- Coverage          44.92%   44.86%   -0.06%     
=================================================
  Files                244      244              
  Lines              13417    13417              
  Branches            2752     2752              
=================================================
- Hits                6027     6019       -8     
- Misses              7085     7094       +9     
+ Partials             305      304       -1     
Flag Coverage Δ
unittests 44.86% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@zyyw zyyw force-pushed the 2.9.5-upgrade-golang-version branch 4 times, most recently from f4ada5a to f8b4517 Compare June 26, 2024 11:41
@zyyw zyyw changed the title upgrade golang to 1.21.11 and bump up dep in go.mod [WIP] upgrade golang to 1.22.4 and bump up dep Jun 26, 2024
@zyyw zyyw marked this pull request as draft June 27, 2024 04:56
fix: upgrade trivy version
fix: upgrade go mod dep

Signed-off-by: Shengwen Yu <[email protected]>
@zyyw zyyw marked this pull request as ready for review June 27, 2024 08:24
@zyyw zyyw force-pushed the 2.9.5-upgrade-golang-version branch from f8b4517 to ffc711f Compare June 27, 2024 08:25
@zyyw zyyw changed the title [WIP] upgrade golang to 1.22.4 and bump up dep upgrade golang to 1.22.4 and bump up dep Jun 27, 2024
@zyyw zyyw merged commit 1977d7b into goharbor:release-2.9.0 Jun 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants