-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary variables from Makefiles #20620
Open
kariya-mitsuru
wants to merge
3
commits into
goharbor:main
Choose a base branch
from
kariya-mitsuru:remove-unnecessary-vars-from-makefile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove unnecessary variables from Makefiles #20620
kariya-mitsuru
wants to merge
3
commits into
goharbor:main
from
kariya-mitsuru:remove-unnecessary-vars-from-makefile
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Makefile - Remove -e option since it is unnecessary when passing variables as command line arguments to `make -f make/photon/Makefile`. (The -e option is used to override variables defined in the Makefile with environment variables.) - Remove DEVFLAG and REGISTRYVERSION from `make -f make/photon/Makefile` command line arguments since they are unused in make/photon/Makefile. - Add TRIVYFLAG to `make -f make/photon/Makefile` command line argument since it is used in make/photon/Makefile. Strictly speaking, this argument is unnecessary, but it is better to have it to explicitly indicate that make/photon/Makefile also uses this variable. - Remove the variable definitions since the following variables are unused. - CONFIGPATH - CORE_PATH - DEVFLAG - DOCKERFILEPATH_COMMON - GOBUILD - GOBUILDMAKEPATH_EXPORTER - GOBUILDPATH_EXPORTER - GOCLEAN - GOCMD - GODEP - GOFMT - GOINSTALL - GOTEST - PORTAL_PATH - PREPAREPATH - SRCPATH - ZIPCMD 2. make/photon/Makefile - Remove the variable definitions since the following variables are unused. - CORE_BINARYNAME - CORE_SOURCECODE - DOCKERFILENAME_POSTGRESQL - DOCKERFILEPATH_POSTGRESQL - DOCKERIMAGENAME_POSTGRESQL - DOCKERIMAGES - JOBSERVICEBINARYNAME - JOBSERVICESOURCECODE - POSTGRESQL - SEDCMD - SRCPATH - TOOLSPATH - WGET - Remove the variable definitions since the following variables are specified as command line arguments when executed from Makefile. - BASEIMAGENAMESPACE - IMAGENAMESPACE Signed-off-by: Mitsuru Kariya <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20620 +/- ##
==========================================
- Coverage 67.56% 66.22% -1.35%
==========================================
Files 991 1045 +54
Lines 109181 113476 +4295
Branches 2719 2845 +126
==========================================
+ Hits 73768 75144 +1376
- Misses 31449 34227 +2778
- Partials 3964 4105 +141
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fix make argument to be executed in the recipe for build_standalone_db_migrator. Signed-off-by: Mitsuru Kariya <[email protected]>
Sorry, I realized I forgot to fix build_standalone_db_migrator target, so I fixed it and pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Makefile
Remove
-e
option since it is unnecessary when passing variables as command line arguments tomake -f make/photon/Makefile
. (The-e
option is used to override variables defined in theMakefile
with environment variables.)Remove
DEVFLAG
andREGISTRYVERSION
frommake -f make/photon/Makefile
command line arguments since they are unused inmake/photon/Makefile
.Add
TRIVYFLAG
tomake -f make/photon/Makefile
command line argument since it is used inmake/photon/Makefile
. Strictly speaking, this argument is unnecessary, but it is better to have it to explicitly indicate thatmake/photon/Makefile
also uses this variable.Remove the variable definitions since the following variables are unused.
CONFIGPATH
CORE_PATH
DEVFLAG
DOCKERFILEPATH_COMMON
GOBUILD
GOBUILDMAKEPATH_EXPORTER
GOBUILDPATH_EXPORTER
GOCLEAN
GOCMD
GODEP
GOFMT
GOINSTALL
GOTEST
PORTAL_PATH
PREPAREPATH
SRCPATH
ZIPCMD
make/photon/Makefile
Remove the variable definitions since the following variables are unused.
CORE_BINARYNAME
CORE_SOURCECODE
DOCKERFILENAME_POSTGRESQL
DOCKERFILEPATH_POSTGRESQL
DOCKERIMAGENAME_POSTGRESQL
DOCKERIMAGES
JOBSERVICEBINARYNAME
JOBSERVICESOURCECODE
POSTGRESQL
SEDCMD
SRCPATH
TOOLSPATH
WGET
Remove the variable definitions since the following variables are specified as command line arguments when executed from
Makefile
.BASEIMAGENAMESPACE
IMAGENAMESPACE
Issue being fixed
Please indicate you've done the following: