Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and refactor vm package #845

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Document and refactor vm package #845

merged 3 commits into from
Apr 21, 2020

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 19, 2020

This PR is for addressing the 2 feedback I got from #841

  1. the vm.New vm.New and v.ExecInstructions methods would profit from some minimal documentation, especially what all the "paths" actually mean. some of them seemed semi obvious..
  2. same for RegisterExternalClass ExternalClass and vm.Method albeit those are relatively clear

@st0012
Copy link
Member Author

st0012 commented Apr 19, 2020

@yannick can you give this a look?

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #845 into master will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage   81.10%   81.11%   +0.01%     
==========================================
  Files          54       54              
  Lines        7420     7419       -1     
==========================================
  Hits         6018     6018              
+ Misses       1179     1178       -1     
  Partials      223      223              
Impacted Files Coverage Δ
vm/class.go 86.07% <0.00%> (ø)
vm/vm.go 83.50% <58.82%> (+0.42%) ⬆️
native/db/db.go 61.00% <100.00%> (ø)
native/plugin/plugin.go 11.96% <100.00%> (ø)
native/ripper/ripper.go 73.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5c001...f5b0c8b. Read the comment docs.

vm/vm.go Outdated Show resolved Hide resolved
vm/vm.go Outdated Show resolved Hide resolved
vm/vm.go Show resolved Hide resolved
@st0012 st0012 merged commit d8cfa98 into master Apr 21, 2020
@st0012 st0012 deleted the document-and-refactor-vm branch April 21, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants