add skip secondary authorization option for public oauth2 clients #31454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/api
denyskon
added
type/enhancement
|
(easier to review with disabled whitespace changes :) |
delvh
reviewed
Jun 28, 2024
Co-authored-by: delvh <[email protected]>
Co-authored-by: delvh <[email protected]>
delvh
approved these changes
Jun 28, 2024
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #30790
Add an option to allow skipping the manual authorization on every request for public clients.
As this measure is not a hard requirement by the OAuth2 spec and all the major competitors of Gitea not implementing it, make it opt-out to allow for consistent user experience and simplified workflow for users who need it.