Traverse xattrs using a pointer to xattr instead of snprintf() its value

[mykaul]

The key can be a pointer, pointing to the xattr, instead of copying it.

Updates: #1000
Signed-off-by: Yaniv Kaul [email protected]

[gluster-ant]

CLANG-FORMAT FAILURE:
Before merging the patch, this diff needs to be considered for passing clang-format

index 83e295eb8..ceb8f81d4 100644
--- a/xlators/storage/posix/src/posix-inode-fd-ops.c
+++ b/xlators/storage/posix/src/posix-inode-fd-ops.c
@@ -6045,10 +6045,7 @@ posix_readdirp(call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size,
         if (op_ret >= 0) {
             op_ret = 0;
 
-            list_for_each_entry(entry, &entries.list, list)
-            {
-                op_ret++;
-            }
+            list_for_each_entry(entry, &entries.list, list) { op_ret++; }
         }
 
         STACK_UNWIND_STRICT(readdirp, frame, op_ret, op_errno, &entries, NULL);

[mykaul]

/run regression

[gluster-ant]

CLANG-FORMAT FAILURE:
Before merging the patch, this diff needs to be considered for passing clang-format

index a4223a690..4b8e0e04e 100644
--- a/xlators/storage/posix/src/posix-inode-fd-ops.c
+++ b/xlators/storage/posix/src/posix-inode-fd-ops.c
@@ -6045,10 +6045,7 @@ posix_readdirp(call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size,
         if (op_ret >= 0) {
             op_ret = 0;
 
-            list_for_each_entry(entry, &entries.list, list)
-            {
-                op_ret++;
-            }
+            list_for_each_entry(entry, &entries.list, list) { op_ret++; }
         }
 
         STACK_UNWIND_STRICT(readdirp, frame, op_ret, op_errno, &entries, NULL);

[mykaul]

/run regression

[gluster-ant]

0 test(s) failed

1 test(s) generated core
./tests/bugs/glusterd/mgmt-handshake-and-volume-sync-post-glusterd-restart.t

2 test(s) needed retry
./tests/00-geo-rep/georep-basic-dr-rsync-arbiter.t
./tests/bugs/glusterd/bug-1696046.t
https://build.gluster.org/job/gh_centos7-regression/3404/

[mykaul]

/run regression

[mykaul]

Filed #4369 on the crash in regression, which I think (hope) is not related to this patch.

[gluster-ant]

0 test(s) failed

1 test(s) generated core
./tests/bugs/glusterd/brick-mux.t

2 test(s) needed retry
./tests/000-flaky/glusterd-restart-shd-mux.t
./tests/bugs/glusterd/brick-mux.t

1 flaky test(s) marked as success even though they failed
./tests/000-flaky/glusterd-restart-shd-mux.t
https://build.gluster.org/job/gh_centos7-regression/3406/