Add download-release.sh for easy install #8044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCrews
force-pushed
the
download-release-script
branch
from
94a30e6
to
dcd0442
Compare
|
Should be moved to the |
mofosyne
added
the
Review Complexity : Medium
|
Will do. Any other top-level comments? Is this even something you want to consider? I also noticed now scripts/server-llm.sh. This has some duplicate functionality with that, since that also installs llama-server, it just does it by building it instead of downloading a release. Perhaps we want to split this into three scripts?
You can choose whichever download- script you need, and then run-server.sh? Idk this might have to be breaking, but we might be able to keep it non-breaking. Or other option would be to merge everything into a mega script, adding this functionality to llm-server.sh, toggleable with a flag? |
NickCrews
force-pushed
the
download-release-script
branch
from
dcd0442
to
ea325e0
Compare
I wanted an easy way to get llama-server on my machine. I figured this would be useful for other people as well. Take a look at the docstring and help text, it should be fairly intuitive. Tested as working on a mac m1. The path handling only works with unixy paths for now, sorry windows people. If you want, this is ripe for improving in this regard. I tried to keep portability in mind besides that though, though I'm no shell expert.
NickCrews
force-pushed
the
download-release-script
branch
from
ea325e0
to
a682156
Compare
|
It's best if the option is merged into the existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted an easy way to get llama-server on my machine.
I figured this would be useful for other people as well.
Take a look at the docstring and help text, it should be fairly intuitive.
Tested as working on a mac m1. The path handling only works with unixy paths for now, sorry windows people. If you want, this is ripe for improving in this regard.
I tried to keep portability in mind besides that though, though I'm no shell expert.