spv-in parse more atomic ops #5824
Draft
+713
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2024
schell
force-pushed
the
feature/spirv-front-atomics-3-more-ops
branch
2 times, most recently
from
870dda3
to
521c26d
Compare
…uppress a double load expression
schell
force-pushed
the
feature/spirv-front-atomics-3-more-ops
branch
from
9c40733
to
6df6ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of
Depends on
Description
This adds parsing for the following atomic operations to
naga::spv::Frontend::next_block:OpAtomicCompareExchangeWeak(deprecated)OpAtomicIIncrementwas included in spv-in parsing Op::AtomicIIncrement #5702Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.