fix(gatsby-plugin-sharp): read aspectRatio from the largest image possible #39008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
gatsby-plugin-sharpreturns theaspectRatioofimages[0], which is the smallest image and likely has the most inaccurateaspectRatio. The fix changesimages[0]toimages[images.length - 1]to use the largest image.Documentation
No documentation is needed since it's an internal fix.
Tests
I've added a unit test to process an image of 1000x746. The accurate
aspectRatioshould be0.746while the smallest image has a ratio of0.7466....Related Issues
Fixes #24212