Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add animations to block 9.2 of the English Curriculum #55197

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat(curriculum): add animations to block 9.2 of the English Curriculum #55197

merged 1 commit into from
Jun 17, 2024

Conversation

DanielRosa74
Copy link
Contributor

Checklist:

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 15, 2024
@DanielRosa74 DanielRosa74 added new english course English Curriculum status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. and removed scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jun 15, 2024
nieldakarla
nieldakarla approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@nieldakarla nieldakarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also sounds great. =)
Notes:
Task 42 I had to click three times to listen all the words, but at the end I could hear them all.

naomi-lgbt
naomi-lgbt approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not encounter the issue on task 42 that Nielda did.

@naomi-lgbt naomi-lgbt merged commit ba776a0 into freeCodeCamp:main Jun 17, 2024
18 checks passed
@DanielRosa74 DanielRosa74 deleted the feat-9.2-dialogues branch June 18, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@nieldakarla nieldakarla nieldakarla approved these changes

Assignees
No one assigned
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielRosa74 @naomi-lgbt @nieldakarla