-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client, curriculum): center images in challenge description #55190
fix(client, curriculum): center images in challenge description #55190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you haven't done it yet, could you include this two? 🙂
Line 12 in dda4bb9
<img class="img-responsive center-block" alt="a 2-dimensional vector of coordinates (2, 3)" src="https://cdn.freecodecamp.org/curriculum/python/2dvector.png" style="background-color: white; height: 350px; width: auto; padding: 15px;"> |
Line 12 in dda4bb9
<img class="img-responsive center-block" alt="a 3-dimensional vector of coordinates (4, 6, 3)" src="https://cdn.freecodecamp.org/curriculum/python/3dvector.png" style="background-color: white; height: 350px; width: auto; padding: 15px;"> |
...hon/learn-algorithm-design-by-building-a-shortest-path-algorithm/6579dd49fa8a8e1fd06b85a9.md
Show resolved
Hide resolved
...hon/learn-algorithm-design-by-building-a-shortest-path-algorithm/6579dd49fa8a8e1fd06b85a9.md
Show resolved
Hide resolved
curriculum/challenges/english/10-coding-interview-prep/data-structures/depth-first-search.md
Show resolved
Hide resolved
...-euler-problems-101-to-200/problem-144-investigating-multiple-reflections-of-a-laser-beam.md
Show resolved
Hide resolved
...sh/18-project-euler/project-euler-problems-101-to-200/problem-194-coloured-configurations.md
Show resolved
Hide resolved
...challenges/english/18-project-euler/project-euler-problems-201-to-300/problem-244-sliders.md
Show resolved
Hide resolved
...challenges/english/18-project-euler/project-euler-problems-201-to-300/problem-244-sliders.md
Show resolved
Hide resolved
...s/english/18-project-euler/project-euler-problems-201-to-300/problem-264-triangle-centres.md
Show resolved
Hide resolved
@Dario-DC Hah, I missed those. Thank you! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @huyenltnguyen.
LGTM 👍
Wondering if this is the best approach. I'm fine with it, but couldn't we do something like Also wondering about other clients. Maybe it will make things more difficult for mobile or other future clients, in that they may have to overwrite the inline styles. Perhaps that's fine. Also now wondering if the left alignment is better - or maybe, good enough. |
The only reason I didn't go with adding the styles in a stylesheet is because there are already inline styles, so keeping the styles in one place is easier to manage.
I was wondering the same. I'm not sure if we want to have inline styles in the curriculum content at all, and was thinking how we could style the content in a different way. I think an alternative approach is to include the desired layout/arrangement in the metadata, similar to the Do you think this approach makes sense, and is it something we can add to CAP / CAP API? |
Thanks Huyen! |
Checklist:
main
branch of freeCodeCamp.This PR fixes an image alignment issue caused by #55068.
Screenshots