Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Curriculum): Corrected tasks feedbacks and descriptions English Curriculum #55151

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

nieldakarla
Copy link
Contributor

@nieldakarla nieldakarla commented Jun 10, 2024

Just fixed some issues reported by Anastasiia.

Checklist:

@nieldakarla nieldakarla added the new english course English Curriculum label Jun 10, 2024
@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 10, 2024
DanielRosa74

This comment was marked as outdated.

Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change suggested to line 36 of file 657e07a2fdda8d5ac93d415e.md

@nieldakarla nieldakarla changed the title Fix pronouns for two tasks on block 2.1 Fix(Curriculum): Corrected tasks feedbacks and descriptions English Curriculum Jun 11, 2024
@nieldakarla nieldakarla marked this pull request as ready for review June 11, 2024 20:18
Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change suggested to 657b6f641e5c3ab1afc6efc1.md

Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielRosa74 DanielRosa74 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 13, 2024
DanielRosa74 and others added 3 commits June 14, 2024 18:10
…rn-conversation-starters-in-the-break-room/657b6ea501ca10ae78922b0d.md

Co-authored-by: Huyen Nguyen <[email protected]>
…rn-conversation-starters-in-the-break-room/657b6f641e5c3ab1afc6efc1.md

Co-authored-by: Huyen Nguyen <[email protected]>
…rn-conversation-starters-in-the-break-room/657b6f641e5c3ab1afc6efc1.md

Co-authored-by: Huyen Nguyen <[email protected]>
@huyenltnguyen huyenltnguyen merged commit 8b52bf6 into freeCodeCamp:main Jun 17, 2024
17 checks passed
@nieldakarla nieldakarla deleted the fix/correct-tasks branch June 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants