Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): added more tests to file: rosetta code Tokenize a string with escaping #55142

Closed
wants to merge 1 commit into from

Conversation

JLH13
Copy link

@JLH13 JLH13 commented Jun 9, 2024

Checklist:

Closes #54687

This file had a comment that it needed more test cases. I added in three more.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 9, 2024
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please properly add new tests. If you have questions you can reach out on Discord or the forum


const testStr3 = 'ab^cd^ef^^gh';
const res3 = ['ab^cd^ef^gh'];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only added some strints and arrays, doing nothing with them, as such, no new test has been added.

@ilenia-magoni ilenia-magoni added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 10, 2024
@Sembauke Sembauke closed this Jun 10, 2024
@Sembauke Sembauke reopened this Jun 10, 2024
@ojeytonwilliams
Copy link
Contributor

Closing as stale.

@ilenia-magoni ilenia-magoni removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add more tests to rosetta code Tokenize a string with escaping
4 participants