Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(curriculum): Wrap strings in quotes in Learn Recursion by Building a Decimal to Binary Converter #55126

Merged

Conversation

altsun
Copy link
Contributor

@altsun altsun commented Jun 8, 2024

Checklist:

Relates to #51036

Overview

Wrap quotes around strings in Learn Recursion by Building a Decimal to Binary Converter

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 8, 2024
@altsun altsun changed the title wrap string with quotes chore(curriculum): Wrap strings in quotes in Learn Recursion by Building a Decimal to Binary Converter Jun 8, 2024
@altsun altsun marked this pull request as ready for review June 8, 2024 11:38
@gikf gikf added the new javascript course These are for issues dealing with the new JS curriculum label Jun 9, 2024
Copy link
Contributor

@RGHANILOO RGHANILOO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope the explanation and examples are a bit clearer.

@altsun altsun force-pushed the chore/add-quotes-binary-converter branch from 73a495f to 9ea4c17 Compare June 11, 2024 11:31
@ojeytonwilliams ojeytonwilliams added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 20, 2024
@huyenltnguyen huyenltnguyen added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jun 25, 2024
@huyenltnguyen huyenltnguyen merged commit f96e9da into freeCodeCamp:main Jun 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants