Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): handle reset after saving learner code #55103

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented Jun 6, 2024

Checklist:

Closes: #55100

Now the behaviour is the same if you save -> reload -> reset or just save -> reset. In both cases the code will be reset to whatever you last saved.

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Jun 6, 2024
@ojeytonwilliams ojeytonwilliams marked this pull request as ready for review June 6, 2024 11:19
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner June 6, 2024 11:19
@naomi-lgbt
Copy link
Member

failing test is from the missing spec file - fixed on main

@ojeytonwilliams ojeytonwilliams added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 13, 2024
@Sembauke Sembauke merged commit 1d1a9da into freeCodeCamp:main Jun 20, 2024
20 checks passed
@ojeytonwilliams ojeytonwilliams deleted the fix/reset-after-save branch June 21, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resetting code in some new JS certification projects is not working
3 participants