Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require cycle in TransitionItem.js #214

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Jonathan0wh
Copy link

Minor fix for #175. This should fix the require cycle warning below when installing the package, by bypassing Utils/index.js:

require.js:114 Require cycle: 
node_modules/react-navigation-fluid-transitions/TransitionItem.js 
-> node_modules/react-navigation-fluid-transitions/Utils/index.js 
-> node_modules/react-navigation-fluid-transitions/Utils/getResolvedMetrics.js 
-> node_modules/react-navigation-fluid-transitions/TransitionItem.js

Require cycles are allowed, but can result in uninitialized values. 
Consider refactoring to remove the need for a cycle.

@kaueDM
Copy link

kaueDM commented Oct 10, 2019

Can someone merge it? Is really annoying this warning in the console.

@chrfalch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants