Fix: Slider inside the ColorPicker did not budge if present color is set to 'Black' #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Hyungeol94 , thanks for the MR. What exactly is the error? Does the slider never work or only when you explicitly set the color to black does it stop working? |
|
Hello @fmeringdal. It happened only for the latter case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the present color was set to "Black," there was a bug in the ColorPicker component that prevented the slider from moving.
If the onChange is called, an alpha value, which is a hsv color type, needs to be injected into the ColorPicker component. This necessity is reflected in the modified version.
I really hope this works.