Add Principal to agent #5481
Draft
Add Principal to agent #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-ebrown
force-pushed
the
add-metadata-to-agent-idl
branch
from
fc1e4bb
to
a3efcd8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5481 +/- ##
==========================================
+ Coverage 60.97% 62.51% +1.54%
==========================================
Files 793 459 -334
Lines 51350 27456 -23894
==========================================
- Hits 31312 17165 -14147
+ Misses 17152 8755 -8397
+ Partials 2886 1536 -1350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddl-ebrown
force-pushed
the
add-metadata-to-agent-idl
branch
3 times, most recently
from
e8e7878
to
bb0e12f
Compare
- Regenerate idl wrappers with `make generate` Signed-off-by: ddl-ebrown <[email protected]>
ddl-ebrown
force-pushed
the
add-metadata-to-agent-idl
branch
from
bb0e12f
to
9c1d883
Compare
- Figuring out the best way to mod the CR and thread through the metadata principal so that flytepropeller can get to it and pass it to the agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link