Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic-launcher: Make desktop file executable #1376

Closed
wants to merge 1 commit into from

Conversation

JakobDev
Copy link
Contributor

The dynamics launcher portal is currently not working under KDE, as KDE requires desktop files to be executable for some reason. This fixes it.

@davidedmundson
Copy link
Contributor

as KDE requires desktop files to be executable for some reason

That's not a completely true story, it shouldn't apply for installed applications, and at most it gives a prompt.

The dynamics launcher portal is currently not working under KDE,

Can you expand on this please.

@JakobDev
Copy link
Contributor Author

That's not a completely true story, it shouldn't apply for installed applications, and at most it gives a prompt.

There is no prompt. It just shows a Notification. The only way to fix this is by making the desktop file executable., which is not suitable for a normal user.

Screenshot_20240610_115850

Can you expand on this please.

The desktop file is installed, but it can't be launched due to missing permission.

@GeorgesStavracas GeorgesStavracas marked this pull request as draft June 18, 2024 11:21
@GeorgesStavracas
Copy link
Member

Changed to draft so nobody accidentally merges it

@Sodivad
Copy link
Contributor

Sodivad commented Jun 21, 2024

Hi this prompt/failure was due to not accounting for desktop files linked into the applications directory
Fixed via https://invent.kde.org/frameworks/kconfig/-/commit/6772deba4c2682f1faf8967ba8200db48528f2b2

@GeorgesStavracas
Copy link
Member

Given the last comment, I'll close this PR. Thanks for looking at it on the KDE side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants