open-uri: bump advertised interface version #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add |
OpenURI in version 4 added support for activation token, but it still advertises older version on DBus. This might make clients checking the version not to use the activation token. Fixes: 39a34ba ("open-uri: Pass activation token around")
|
@GeorgesStavracas can you please look into this? It's really simple and straighforward. Or do you mind @swick to approve simple changes like this one? It would be great to give more people trust to approve PRs and avoid reviews to be pending for long time than necessary. |
GeorgesStavracas
approved these changes
Jun 18, 2024
Sebastian's reviews are super helpful, of course, but the more eyes the better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenURI in version 4 added support for activation token, but it still advertises older version on DBus. This might make clients checking the version not to use the activation token.