document/fuse: Provide the document host path as xattr #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/document-portal-xattr-host-path
branch
from
2ed37b1
to
702c281
Compare
|
This is missing documentation. Not sure where to put it. |
GeorgesStavracas
added
enhancement
portal: documents
GeorgesStavracas
approved these changes
Jun 20, 2024
swick
force-pushed
the
wip/document-portal-xattr-host-path
branch
from
702c281
to
aab55ac
Compare
|
Added a sentence to the document portal's |
tristan957
reviewed
Jun 20, 2024
Setting res to ENODATA will call fuse_reply_buf with some number which indicates the buffer has been filled with that many bytes. That's a lie. The intend here is to return an error, so properly do so. Fixes: 1a8ab1f ("document-portal: Expose directory documents as a subdirectory")
swick
force-pushed
the
wip/document-portal-xattr-host-path
branch
from
aab55ac
to
a138ef7
Compare
swick
force-pushed
the
wip/document-portal-xattr-host-path
branch
from
a138ef7
to
6b52832
Compare
tristan957
approved these changes
Jun 20, 2024
|
Added a commit at the beginning which fixes an existing bug and fixed some error reporting in the host path xattr found by @tristan957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementing #1364, this provides the host path as an xattr via the document portal fuse fs.