XdpAppInfo refactoring, Part 2 #1369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/xdp-app-info-subclasses
branch
3 times, most recently
from
1c5df96
to
aaf69ba
Compare
swick
force-pushed
the
wip/xdp-app-info-subclasses
branch
from
aaf69ba
to
a034dff
Compare
They are only used internally and there is no reason to expose them in the header.
This helps decoupling the util function from the XdpAppInfo.
Gets the value set by xdp_set_documents_mountpoint. This helps decoupling the utils from the XdpAppInfo further.
This allows us to have a clean split between utils and the XdpAppInfo which has become a complex free standing thing.
This moves around some functions so related code is close to each other and also fixes the formatting of functions arguments. There are no functional changes at all.
This deprecates impl.portal.Background.EnableAutostart. It turns out portal backends implement this the same because there is no user interaction and creating a file at the right place doesn't allow for much divergence. How the autostart file has to look however can depend on the kind of app it is supposed to start. I.e. a flatpak app needs to change the Exec line and wants to set X-Flatpak.
We encapsulate all the differences in XdpAppInfo now so there is no need to expose what kind of app the instance is of. We still have xdp_app_info_is_host to allow checking for a more privileged process but we should try to get rid of it in the future as well.
They are unused now that we have validate_autostart and validate_dynamic_launcher.
We start using -private.h files to separate API from things we have to expose for other reasons, like tests. This also starts marking symbols with XDP_EXPORT and XDP_EXPORT_TEST which helps documenting their use.
This implements XdpAppInfo subclasses for host, tests, flatpak and snap. They are unused for now and will get instantiated by a later commit.
They are initialized by xdp_app_info_initialize when the object gets created and will stay valid until it is disposed. A later commit will start using them to implement existing functions.
The pidns is derived from the pidfd of a process from within the same pidns as the app.
Now that pid mapping is done by getting the pidns from the XdpAppInfo and then using xdp-utils to do the actual mappings, we can remove the mapping functionality from XdpAppInfo.
There is no remaining user of this function so we can make it private and remove it from the header.
Implement existing functions using the new private fields of XdpAppInfo and the new vfuncs of the class. Also instantiate the subclasses. This allows us to remove the app info kind and the kind specific fields from XdpAppInfo and delegates all of that to the subclasses.
swick
force-pushed
the
wip/xdp-app-info-subclasses
branch
from
a034dff
to
40f1779
Compare
|
Rebased on top of the changes from Part 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1366.
This moves the app info kind specific code to subclasses, the pid mapping stuff to utils and reduces the scope of XdpAppInfo.