Uniformize application as app #1327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was asked to ack, LGTM 👍 |
snwh
reviewed
Apr 10, 2024
| @@ -751,7 +751,7 @@ handle_request_background_in_thread_func (GTask *task, | |||
| subtitle = g_strdup_printf (_("%s requests to be started automatically and run in the background."), info ? g_app_info_get_display_name (info) : id); | |||
| else | |||
| subtitle = g_strdup_printf (_("%s requests to run in the background."), info ? g_app_info_get_display_name (info) : id); | |||
| body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the application settings.")); | |||
| body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the app settings.")); | |||
There was a problem hiding this comment.
is this referring to the settings for the app, or to Applications settings found in Settings apps?
There was a problem hiding this comment.
Application settings found in Settings app. But what about other DEs on this and "app" name?
There was a problem hiding this comment.
If this is the case, then it would be good to have this be "applications settings" since it would be referring to general settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniformize occurrences of "application"(s) and "app"(s) as the latter.
Occurrences of application(s):
src/background.c, line 754
The ‘run in background’ permission can be changed at any time from the application settings.
src/location.c, line 566
An application wants to use your location.
src/screenshot.c, line 265
Allow Applications to Take Screenshots?
src/screenshot.c, line 266
An application wants to be able to take screenshots at any time.
src/wallpaper.c, lines 215 and 216
Allow Applications to Set Backgrounds?
An application is requesting to be able to change the background image.
Occurrences of app(s):
src/device.c, line 122 and 123, 137 and 138
Allow app to Use the Microphone?
An app wants to access recording devices.
Allow app to Use the Speakers?
An app wants to access audio devices.
src/device.c, lines 152 and 153
Allow app to Use the Camera?
An app wants to access camera devices.
src/dynamic-launcher.c, lines 131 and 719
Desktop file id missing app id prefix '%s.': %s
RequestInstallToken() not allowed for app id %s