Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Docker image to use Flathub's flatpak-builder-lint #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barthalion
Copy link
Member

This way, all tools match the one used on Flathub infra, and reduce potential breakage caused by Fedora bumping packages.

This way, all tools match the one used on Flathub infra, and reduce
potential breakage caused by Fedora bumping packages.
@tytan652
Copy link
Contributor

tytan652 commented Dec 12, 2023

This image switch look like it will breaks CIs (actions consumer) that relies on dnf to install some tools which is a big issue.

Images on Docker Hub should not have such a breakage.

Edit: It can be good base image for Github registry images (#60).

@barthalion
Copy link
Member Author

The fact dnf was available was at best an implementation detail, and not something action users should rely on in the first place.

@tytan652
Copy link
Contributor

This way, all tools match the one used on Flathub infra, and reduce potential breakage caused by Fedora bumping packages.

Isn't org.flatpak.Builder going to do the same when it will bump flatpak-builder to 1.4 ?
Yes, less frequently but it still can happen.

@barthalion
Copy link
Member Author

It's obviously not being bumped to 1.4 until it's actually functional.

@bilelmoussaoui
Copy link
Member

Note that I am not a fan of tying the base image with flathub infrastructure and decisions. so please don't merge this until we figure out a way to split the base image provided by the flatpak action and flathub specific bits

@barthalion
Copy link
Member Author

Until this is resolved one way or another, I will be maintaining a soft fork at https://github.com/flathub-infra/flatpak-github-actions/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants