Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertexAI: use shared repository for test golden files #13186

Merged
merged 8 commits into from
Jun 26, 2024
Merged

VertexAI: use shared repository for test golden files #13186

merged 8 commits into from
Jun 26, 2024

Conversation

tanzimfh
Copy link
Member

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

andrewheard
andrewheard approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tanzim, this looks great! Just the #!/bin/bash to add to the script and the rest is personal preference/nits.

cc: @rlazo

scripts/update_vertexai_responses.sh Outdated Show resolved Hide resolved
scripts/update_vertexai_responses.sh Show resolved Hide resolved
@tanzimfh tanzimfh marked this pull request as ready for review June 26, 2024 19:26
andrewheard
andrewheard approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all LGTM now!

@tanzimfh tanzimfh merged commit 18e5d6b into main Jun 26, 2024
61 checks passed
@tanzimfh tanzimfh deleted the tanzim/migration2 branch June 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanzimfh @google-oss-bot @andrewheard