Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): metadata handling of manifests #374

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(core): metadata handling of manifests #374

wants to merge 13 commits into from

Conversation

Dacksus
Copy link
Contributor

@Dacksus Dacksus commented May 24, 2024 •
edited
Loading

  • adds separation of functional description and metadata of nodes and edges for dialogues
  • adds separation of functional description and metadata of models for protocols
  • cached protoco.digest to avoid unnecessary recomputation

note: Models can't have fields that are named "description"!

@Dacksus Dacksus changed the title manifest refactor wip feat: metadata handling of manifests May 27, 2024
@Dacksus Dacksus marked this pull request as ready for review May 27, 2024 14:39
@Dacksus
Copy link
Contributor Author

Dacksus commented May 27, 2024

updated model digestion (to use pydantic v2). -> Needs refactoring throughout the framework to update deprecated function calls (see tests)

@Dacksus Dacksus requested review from Archento and jrriehl May 27, 2024 14:42
@Archento Archento changed the title feat: metadata handling of manifests feat(core): metadata handling of manifests May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archento Archento Awaiting requested review from Archento

@jrriehl jrriehl Awaiting requested review from jrriehl jrriehl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dacksus @Archento