Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CI upgrade to Node 22 + TS 5.5 #10119

Merged
merged 11 commits into from
Jun 21, 2024
Merged

chore: CI upgrade to Node 22 + TS 5.5 #10119

merged 11 commits into from
Jun 21, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 9, 2024

Motivation

CI should use Node 20/LTS by default

Matrix strategies should use Node versions 18.0, 20, 22


Note TSC has a segmentation fault under Node 22. Apparently, this is related to a V8 maglev bug. This also upgrades to TS 5.5 which fixes the problem on TS side.

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 9, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 9, 2024 12:47
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 9, 2024
Copy link

netlify bot commented May 9, 2024

[V2]

Name Link
🔨 Latest commit 786ebd1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6675654b606c180008a33242
😎 Deploy Preview https://deploy-preview-10119--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 9, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 80 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented May 9, 2024

Size Change: +8.96 kB (+0.49%)

Total Size: 1.85 MB

Filename Size Change
website/build/assets/js/main.********.js 906 kB +8.96 kB (+1%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 27.1 kB
website/.docusaurus/globalData.json 123 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 304 kB
website/.docusaurus/routes.js 202 kB
website/.docusaurus/routesChunkNames.json 130 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 112 kB
website/build/index.html 38.1 kB

compressed-size-action

@slorber slorber marked this pull request as draft May 9, 2024 16:08
Copy link

@JhonySpark JhonySpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@slorber slorber changed the title chore: CI upgrade to Node 22 chore: CI upgrade to Node 22 + TS 5.5 Jun 21, 2024
@slorber slorber marked this pull request as ready for review June 21, 2024 11:52
@slorber slorber merged commit 4ad425a into main Jun 21, 2024
32 checks passed
@slorber slorber deleted the slorber/bump-node-22-ci branch June 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants