Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl: add support for filtering by {min,max} x {create,mod} x {revision} #18233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

etcdctl: add support for filtering by {min,max} x {create,mod} x {revision} #18233

wants to merge 1 commit into from
+158 −14

Conversation

jcferretti
Copy link

etcdctl is missing options to modify get opts for WithMinCreateRev, WithMaxCreateRev, WithMinModRev, WithMaxModRev.

@k8s-ci-robot
Copy link

Hi @jcferretti. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcferretti jcferretti changed the title Add support for filtering by {min,max} x {create,mod} x {revision} to etcdctl. etcdctl: add support for filtering by {min,max} x {create,mod} x {revision} Jun 25, 2024
@henrybear327
Copy link
Contributor

/ok-to-test

@jcferretti please remember to sign-off your commits! Thanks!

@jcferretti
Copy link
Author

/retest

jmhbnz
jmhbnz approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @jcferretti

Once merged please raise an update to changelog for 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
area/etcdctl area/testing ok-to-test size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcferretti @k8s-ci-robot @henrybear327 @jmhbnz