Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cm: moving exception throwing to absl::Status #34904

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

adisuissa
Copy link
Contributor

Commit Message: cm: moving exception throwing to absl::Status
Additional Description:
Removing a few exception throws from cluster-manager.
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34904 was opened by adisuissa.

see: more, trace.

@adisuissa
Copy link
Contributor Author

/retest

@adisuissa adisuissa marked this pull request as ready for review June 26, 2024 02:43
@adisuissa
Copy link
Contributor Author

/assign @alyssawilk

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@alyssawilk alyssawilk merged commit 2d9caa0 into envoyproxy:main Jun 26, 2024
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants