cluster: moving towards no exceptions #34896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
wbpcode
previously approved these changes
Jun 27, 2024
Comment on lines
+1055
to
+1056
| using ProtocolOptionsHashMap = | ||
| absl::flat_hash_map<std::string, ProtocolOptionsConfigConstSharedPtr>; |
There was a problem hiding this comment.
This alias could be moved to above and be used in the parseExtensionProtocolOptions method.
Signed-off-by: Alyssa Wilk <[email protected]>
|
sorry one more fix - one of the prior PRs caused problems interanlly because the constructor was private and there were internal subclasses. trying to head that off here. |
wbpcode
approved these changes
Jun 28, 2024
|
ci... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176