Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Allow extra args to method attribute of ListeningAction. #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ENH: Allow extra args to method attribute of ListeningAction. #43

wants to merge 4 commits into from

Conversation

agrawalprash
Copy link
Contributor

No description provided.

@prabhuramachandran
Copy link
Member

@epatters -- can you please review this?

@WarrenWeckesser
Copy link

Needs a unit test.

@epatters
Copy link
Contributor

This looks fine to me.

It would be nice to add a unit test, but I'm not going to require that you do so since ListeningAction has no tests to begin with. However, if you write some tests, you will have my gratitude :)

@dpinte dpinte added this to the 4.6.0 version milestone Mar 13, 2015
@rahulporuri rahulporuri added this to Backlog in Enthought OSS Jul 13, 2020
@rahulporuri rahulporuri removed this from the 4.6.0 version milestone Jul 13, 2020
@rahulporuri rahulporuri removed this from Backlog in Enthought OSS Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@agrawalprash @prabhuramachandran @WarrenWeckesser @epatters @dpinte @rahulporuri