Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-11025: Remove 'window phone' from @enact/core/platform #3133

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sjro
Copy link
Contributor

@sjro sjro commented Mar 14, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Microsoft ended support for windows mobile on December 10, 2019
So there is no need to keep windows phone on the list of platforms that enact recognizes.

Resolution

Remove 'windows phone' from packages/core/platform/platform.js

Additional Considerations

Links

WRP-11025

Comments

Enact-DCO-1.0-Signed-off-by: SJ RO ([email protected])

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a68c7ec) 81.51% compared to head (61cb34a) 81.51%.

❗ Current head 61cb34a differs from pull request most recent head 038830d. Consider uploading reports for the commit 038830d to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3133   +/-   ##
========================================
  Coverage    81.51%   81.51%           
========================================
  Files          152      152           
  Lines         7109     7109           
  Branches      1868     1868           
========================================
  Hits          5795     5795           
  Misses        1026     1026           
  Partials       288      288           
Impacted Files Coverage Δ
packages/core/platform/platform.js 90.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant