imap: synchronize a fully fetched message w/ local db #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I'm worried this might significantly slow down IMAP responses, but I don't know if there's a better way to fix it. |
|
Ah, this doesn't actually fetch the messages more often, this just stores more info in the DB. |
|
Hm. Does this rely on the order in which the client performs requests? e.g. if the client doesn't trigger |
Closed
not sure I have the required know-how to be able to answer that question. sorry. |
The messages list is first retrieved from Proton via the /messages call. A JSON representation of each of these messages is saved in a local db. However, the retrieved JSON description doesn't include the MIMEType field which is left empty. This CL fixes this by always sync'ing the local db with the full message description as soon as it's retrieved from Proton. Fixes emersion#112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages list is first retrieved from Proton via the /messages call.
A JSON representation of each of these messages is saved in a local db.
However, the retrieved JSON description doesn't include the MIMEType
field which is left empty.
This CL fixes this by always sync'ing the local db with the full message
description as soon as it's retrieved from Proton.
Fixes #112.