Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numbers in retrieval statistics #988

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

orionw
Copy link
Contributor

@orionw orionw commented Jun 25, 2024

Update the retrieval statistics to match the new metadata processing.

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@orionw
Copy link
Contributor Author

orionw commented Jun 25, 2024

@KennethEnevoldsen @isaac-chung I replaced one of the keys with the full information.

How do we want to break this up to fit in the existing schema?

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks very good. We can def. keep this as is.

@orionw orionw changed the title WIP: Update numbers in retrieval statistics Update numbers in retrieval statistics Jun 26, 2024
@orionw orionw marked this pull request as ready for review June 26, 2024 17:35
@orionw
Copy link
Contributor Author

orionw commented Jun 26, 2024

I think I got every retrieval dataset, except for MSMarcoV2. My machine unfortunately died every time I tried to calculate it, apparently it requires a lot of RAM.

Edit: the tests failing appears to be a pydantic error. I am fairly new to pydantic and their error messages confuse me a bit -- @isaac-chung do you have any ideas on what is wrong?

@isaac-chung
Copy link
Collaborator

isaac-chung commented Jun 26, 2024

@orionw the pydantic error seems to be related to the presence of "task_name" in some dicts, e.g. mteb/tasks/Retrieval/dan/TV2Nordretrieval.py. The validation checks for a dict of {str:float} (for other tasks) or {str:{str: dict}} (for this change). The extra key will make it upset.

@orionw
Copy link
Contributor Author

orionw commented Jun 26, 2024

Ah thank you! I tried to delete all of them but clearly missed some. I'll update it. EDIT: you're fast, you already did - thanks!

@isaac-chung
Copy link
Collaborator

I'll try to run calculate_metadata_metrics for MSMARCOv2 on my machine.
Otherwise this is good to merge :D

@orionw
Copy link
Contributor Author

orionw commented Jun 26, 2024

Thanks @isaac-chung!! Good luck, it takes quite a while!

TBH if neither of us can load it, perhaps we need a more efficient dataset loader or simply to remove MSMarcoV2 from our list. My machine had quite a lot of RAM so it's pretty inaccessible -- looking at the specs on IR datasets it has 138 million passages!!

@isaac-chung
Copy link
Collaborator

Wow!
It seems to be running still. I'll give it till the morning (GMT+3) and report back.

@isaac-chung
Copy link
Collaborator

It went OOM killed already. Let's merge this and consider our options with MSMARCOv2.

@isaac-chung isaac-chung merged commit 10c3fbf into main Jun 26, 2024
7 checks passed
@isaac-chung isaac-chung deleted the update_retrieval_stats branch June 26, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants