Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Feature/reimplements string setting in java #16251

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

[WIP]Feature/reimplements string setting in java #16251

wants to merge 22 commits into from

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Jun 24, 2024

Built on top of #15679

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

andsel added 22 commits June 20, 2024 14:27
@andsel
Reimplemented base Setting class in Java as used the original as a wr…
cd37c2e 
…apper around the new one
@andsel
Updated ruby Setting to use configure also the validator callback in …
2746a7d 
…the wrapped Java Setting
@andsel
Use the paramater for default value and not the Setting's field, else…
b550d70 
… it's null
@andsel
Use the name field from the Java wrapped setting. Added 'deprecate' m…
4c12386 
…ethod to create a copy of the wrapped Java Setting with the deprecated setting name
@andsel
Removed strict field from Ruby Setting class, using the one from the …
40d137e 
…wrapped Java Setting class
@andsel
Removed @value_is_set field from Ruby Setting class, using the one fr…
bb397db 
…om the wrapped Java Setting class
@andsel
Removed @value field from Ruby Setting class, using the one from the …
eb7a925 
…wrapped Java Setting class
@andsel
Removed Ruby Setting usage of default field to prefer the Java Settin…
6324292 
…g one
@andsel
Renamed Java Setting method from defaultValue to getDefault
33fa629
@andsel
Reimplemented method Setting.format in Java
bbddb8f
@andsel
[WIP] try to fix the test that apparently doesn't mock a setting once…
d597428 
… retrieved from the DLQ
@andsel
[minor] cleaned commented or debug code
0a7ba88
@andsel
Removed commented or debug code
21d598f
@andsel
Implemented the delegator of Setting and wrapping of an aliased setting
278d3af
@andsel
Replaced I18n reference id in deprecation logs with english translation
fec7b2d
@andsel
Introduced Java implementation of Coercible setting
97fe10d
@andsel
Renamed Java BooleanSetting class to Boolean to syntatically replace …
0d57240 
…the Ruby class
@andsel
Added license header to all newly created files
6fbae76
@andsel
Implemented Nullable subclass setting
aabe115
@andsel
Added missing Boolean setting constructor and fixed vicibility issue …
aee0a31 
…in SettingWithDeprecatedAlias
@andsel
[skip ci] Minor, added license header to new file and removed comment
182cc9a
@andsel
[WIP] Move String setting from Ruby to Java
9ffa8d4
@andsel andsel self-assigned this Jun 24, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 24, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @andsel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andsel andsel

Labels
status:work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andsel @elasticmachine @jsvd