-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow developers to supply their own function to infer column data types from data while loading CSVs #7142
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7142 +/- ##
==========================================
+ Coverage 68.55% 68.57% +0.01%
==========================================
Files 1259 1259
Lines 255844 255969 +125
Branches 26434 26452 +18
==========================================
+ Hits 175392 175518 +126
- Misses 73717 73718 +1
+ Partials 6735 6733 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…has less columns than the others
This reverts commit 5a2ee30. # Conflicts: # src/Microsoft.Data.Analysis/DataFrame.IO.cs
@JakeRadMSFT @luisquintanilla can I get you 2 to take a look at this please? |
Is anyone looking at this? |
@sevenzees I can take a look later today. @JakeRadMSFT @luisquintanilla can you 2 please take a look at this. |
Fixes #7141
Currently when you use
LoadCsv
orLoadCsvFromString
without supplying data types for each column, the code will try to guess the data types based on the data in the CSV file. This is good, but the problem is that the default type inference code only considersbool
,float
,DateTime
, andstring
for column types. Sometimes the user may need another data type, such asint
,long
, ordouble
(see issue 6347 for an example where someone had a problem with thefloat
data type that was chosen by default) but not know the structure of the data ahead of time.I would like to be able to pass in my own custom type inference logic to override the default
GuessKind
implementation that is given in the library right now. If no custom guess type function is provided to theLoadCsv
orLoadCsvFromString
methods, then the code should work the same as it does today.