-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ICanSummarize and implement IEstimator.Summary for StandardTrainers #6584
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@@ -42,7 +42,6 @@ | |||
<ProjectReference Include="..\Microsoft.ML.OnnxTransformer\Microsoft.ML.OnnxTransformer.csproj" /> | |||
<ProjectReference Include="..\Microsoft.ML.SearchSpace\Microsoft.ML.SearchSpace.csproj"> | |||
<PrivateAssets>all</PrivateAssets> | |||
<IncludeInNuget>true</IncludeInNuget> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does removing this line break anything?
@@ -3,8 +3,10 @@ | |||
// See the LICENSE file in the project root for more information. | |||
|
|||
using System.Runtime.CompilerServices; | |||
using Microsoft.ML; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this using statement needed here? Doesn't seem like it.
@@ -2,7 +2,6 @@ | |||
|
|||
<PropertyGroup> | |||
<TargetFramework>netstandard2.0</TargetFramework> | |||
<IncludeInPackage>Microsoft.ML.Core</IncludeInPackage> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What package is this going to be included in now?
|
||
namespace Microsoft.ML.SearchSpace | ||
{ | ||
internal class Schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change the name of this class from Schema to something else? We already use schema for many things, and this seems more like a summary rather than a schema.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.#6563
This PR adds a
Summary
function to allIEstimator<ITransformer>
which prints meta data like estimator name, hyper-parameters and other informations. This helps code generator in model builder to generate pipeline code.