Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document sql source reflection level and type adapter #1467

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

steinitzu
Copy link
Collaborator

Description

Docs for dlt-hub/verified-sources#487

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit f46c6a1
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/667557b8d903000008254318
😎 Deploy Preview https://deploy-preview-1467--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash burnash added the documentation Improvements or additions to documentation label Jun 19, 2024
import dlt
from snowflake.sqlalchemy import TIMESTAMP_NTZ
import sqlalchemy as sa
from sqlalchemy.sql.sqltypes import TypeAdapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail with
Module "sqlalchemy.sql.sqltypes" has no attribute "TypeAdapter"

may be you meant from pydantic import TypeAdapter ? or what version of sqlalchemy you have?

@AstrakhantsevaAA AstrakhantsevaAA self-assigned this Jun 21, 2024
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steinitzu, could you fix the snippet, sqlalchemy.sql.sqltype doesn't have TypeAdapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants