Fixed #32915 -- Refactored runserver command to restore traceback #18260
+57
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The traceback for `runserver --nostatic` with broken/missing
settings was hidden because the custom runserver command which
added `--nostatic` to the command args was only instantiated if
the settings had no errors.
charettes
reviewed
Jun 10, 2024
| @@ -6,6 +6,7 @@ | |||
| from datetime import datetime | |||
|
|
|||
| from django.conf import settings | |||
| from django.contrib.staticfiles.handlers import StaticFilesHandler | |||
There was a problem hiding this comment.
Isn't this going or be problem if django.contrib.staticfiles is not part of INSTALLED_APPS?
I think that changes should be made to the staticfiles provided command instead if any.
The moment django.contrib.staticfiles is added to INSTALLED_APPS calling runserver should resolve to the override in staticfiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-32915
Branch description
The traceback for
runserver --nostaticwith broken/missing settings was hidden because the custom runserver command which added--nostaticto the command args was only instantiated if the settings had no errors.Previous PRs: #1637, 14622
Checklist
mainbranch.