Ticket #35507 changed to search landmark in filter sidebar in order to improve accessibility. #18256
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
There was a problem hiding this comment.
Roughly adding the same comment in the ticket but this basically reverts the work of ticket-34835 which was introduced in 5.1, makes me think we should backport this to 5.1 before the beta freeze and mark this as a release blocker if we are instead saying this is in fact more accurate. Otherwise, we can close this ticket and PR as wontfix.
We will also need to update the release note added in ticket-34835.
cc @django/accessibility team for advice here
| @@ -73,7 +73,7 @@ | |||
| </div> | |||
| {% block filters %} | |||
| {% if cl.has_filters %} | |||
| <nav id="changelist-filter" aria-labelledby="changelist-filter-header"> | |||
There was a problem hiding this comment.
We also have <form id="changelist-search" method="get" role="search"> in django/contrib/admin/templates/admin/search_form.html should we add an aria-label here as described in labelling landmarks?
There was a problem hiding this comment.
We should yes. For some reason I thought we had this already but it looks like I was looking at the wrong thing.
Trac ticket number
ticket-35507
Branch description
changed to search landmark in filter sidebar in order to improve accessibility.
Checklist
mainbranch.