Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #7904 - manage.py cms fixtree also fixes PageUrl model #7905

Open
wants to merge 7 commits into
base: develop-4
Choose a base branch
from

Conversation

jrief
Copy link
Contributor

@jrief jrief commented May 3, 2024

Description

This fixes #7904 – check for details

Checklist

No test yet. Any hint which existing test I can use as a starting point. Needs a tree and associated page and PageUrl objects.

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@jrief jrief changed the title fix #7904: manage.py cms fixtree also fixes PageUrl model fix: #7904 - manage.py cms fixtree also fixes PageUrl model May 3, 2024
@fsbraun fsbraun added the 4.1 label May 8, 2024
@fsbraun
Copy link
Sponsor Member

fsbraun commented Jun 18, 2024

@jrief Can you complete the test with some assertion that ensures the url tree is also fixed? I assume this will only require some additional assertions in the test_management.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review required
Development

Successfully merging this pull request may close these issues.

[BUG] manage.py cms fixtree does not repair model PageUrl
3 participants