DEV: Remove summarization code #27373
Draft
+33
−1,535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chat
romanrizzi
requested changes
Jun 10, 2024
| @@ -10,9 +10,11 @@ def get_summary | |||
| channel = Chat::Channel.find(params[:channel_id]) | |||
| guardian.ensure_can_join_chat_channel!(channel) | |||
|
|
|||
| strategy = Summarization::Base.selected_strategy | |||
| strategy = DiscourseAi::Summarization::Models::Base.selected_strategy | |||
There was a problem hiding this comment.
Chat summaries now depend on a plugin that it's not always installed.
There was a problem hiding this comment.
Indeed, chat must follow the same idea of having it's AI summarization bits extracted and moved into the plugin or simply deleted.
github-actions
bot
removed
the
i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any code related to summarization. Any logic for handling summarization will now return to being handled by the
discourse-aiplugin. See PR: discourse/discourse-ai#658 for the logic being added back todiscourse-ai.