Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve core v2 init API [MD-441] #9560

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Jun 24, 2024

Ticket

MD-441

Description

Eliminate DefaultConfig and only use UnmanagedConfig in core_v2 init API

Test Plan

e2e_test pass

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@gt2345 gt2345 requested a review from a team as a code owner June 24, 2024 21:15
@cla-bot cla-bot bot added the cla-signed label Jun 24, 2024
@gt2345 gt2345 requested review from azhou-determined and removed request for MikhailKardash June 24, 2024 21:15
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 80e8f8a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6679e1f16e7a0c000942879c

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.80%. Comparing base (da9025b) to head (80e8f8a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9560   +/-   ##
=======================================
  Coverage   49.79%   49.80%           
=======================================
  Files        1247     1247           
  Lines      162235   162235           
  Branches     2888     2888           
=======================================
+ Hits        80793    80804   +11     
+ Misses      81270    81259   -11     
  Partials      172      172           
Flag Coverage Δ
backend 43.89% <ø> (+0.02%) ⬆️
harness 63.74% <ø> (ø)
web 46.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant