feat: Add selection label to FlatRuns page #9548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thiagodallacqua-hpe
force-pushed
the
thiago/ET-309
branch
from
d3d222e
to
f7a62b9
Compare
keita-determined
requested changes
Jun 20, 2024
thiagodallacqua-hpe
force-pushed
the
thiago/ET-309
branch
from
602f744
to
a9d016b
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-309
branch
from
a9d016b
to
d49a754
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9548 +/- ##
==========================================
- Coverage 51.36% 46.27% -5.09%
==========================================
Files 1252 929 -323
Lines 152174 123048 -29126
Branches 3024 3024
==========================================
- Hits 78159 56941 -21218
+ Misses 73857 65949 -7908
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
thiagodallacqua-hpe
force-pushed
the
thiago/ET-309
branch
from
d49a754
to
6a1485b
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-309
branch
from
4cbb0ce
to
f6ece9f
Compare
keita-determined
requested changes
Jun 26, 2024
| @@ -986,6 +1015,11 @@ const FlatRuns: React.FC<Props> = ({ projectId, searchId }) => { | |||
| rowHeight={globalSettings.rowHeight} | |||
| onRowHeightChange={onRowHeightChange} | |||
| /> | |||
| {!isMobile && ( | |||
| <span className={css.runSelection} data-test="runSelection"> | |||
There was a problem hiding this comment.
can we add test cases?
There was a problem hiding this comment.
there's a separate ticket for adding test cases for this file...
There was a problem hiding this comment.
i think tests need to be in the same PR. AFAIK, that's what we agreed in the meeting for the reliability
thiagodallacqua-hpe
force-pushed
the
thiago/ET-309
branch
2 times, most recently
from
30f25df
to
f40561c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ET-309
Description
Add the selection label to the flat runs table.
Test Plan
Checklist
docs/release-notes/.See Release Note for details.