-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use post for searchRuns/use accurate multitrial detection #9546
fix: use post for searchRuns/use accurate multitrial detection #9546
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/actions-flat-run-table #9546 +/- ##
===============================================================
Coverage 51.27% 51.27%
===============================================================
Files 1252 1252
Lines 152000 151993 -7
Branches 3017 3017
===============================================================
- Hits 77937 77934 -3
+ Misses 73904 73900 -4
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM
`%22%2C%22value%22%3A0.1%7D%5D%2C%22conjunction%22%3A%22and%22%2C%22kind` + | ||
`%22%3A%22group%22%7D%2C%22showArchived%22%3Afalse%7D`, | ||
), | ||
testRequest('POST', '/api/v1/runs', JSON.stringify({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should run the perf test once to confirm that this is working. I think it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran it -- needed to stringify the filter param. rerunning now.
0fe119f
to
f61cde3
Compare
can we fix the conflicts? i'll review it afterwards |
e538aa6
to
26a8608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -126,7 +126,7 @@ export const RunFilterInterstitialModalComponent = forwardRef<ControlledModalRef | |||
const results = await searchRuns( | |||
{ | |||
filter: JSON.stringify(filter), | |||
limit: 0, | |||
limit: -2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: what does -2
mean in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-2
returns empty results, leaving just the pagination.
@keita-determined fixed -- i did a little code golfing before committing which didn't work out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working good with many experiments
out of scope: do we want it in the experiment table as well, or just flat run since we eventually remove the experiment table?
we do, but I want to bundle that work with leveraging some other things we can do to reduce the backend complexity now that the parameters don't have to be strings. here's the ticket: https://hpe-aiatscale.atlassian.net/browse/ET-602 |
eb25bae
into
feature/actions-flat-run-table
Description
this fixes a few issues with the multitrial check for run actions
Test Plan
Checklist
docs/release-notes/
See Release Note for details.