-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: longrunning tests to ignore multiRM marked e2e tests #9514
Open
amandavialva01
wants to merge
8
commits into
wksp-namespace-binding
Choose a base branch
from
amanda/longrunningTestsToIgnoreMultiK8sTests
base: wksp-namespace-binding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: longrunning tests to ignore multiRM marked e2e tests #9514
amandavialva01
wants to merge
8
commits into
wksp-namespace-binding
from
amanda/longrunningTestsToIgnoreMultiK8sTests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espace bindings (#9226)
JComins000
approved these changes
Jun 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## wksp-namespace-binding #9514 +/- ##
=======================================================
Coverage 48.91% 48.92%
=======================================================
Files 1238 1238
Lines 161348 161348
Branches 2783 2783
=======================================================
+ Hits 78931 78941 +10
+ Misses 82242 82232 -10
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. |
68a1c66
to
2f26288
Compare
5b4fd87
to
c71d596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
No ticket.
Description
End-to-end tests in the long-running workflow use clusters from an isolated GCP project that doesn't have vast visibility, making them difficult to use for multiRM / multi-cluster testing. The shared cluster(s), having better visibility and long-standing setups, are more usable for multiRM testing. Filter out multiRM tests from long-running tests and run any necessary multiRM end-to-end GKE tests in the shared cluster workflow.
Test Plan
CI passes (particularly, long-running workflow passes)
Checklist
docs/release-notes/
.See Release Note for details.