Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: longrunning tests to ignore multiRM marked e2e tests #9514

Open
wants to merge 8 commits into
base: wksp-namespace-binding
Choose a base branch
from

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Jun 13, 2024

Ticket

No ticket.

Description

End-to-end tests in the long-running workflow use clusters from an isolated GCP project that doesn't have vast visibility, making them difficult to use for multiRM / multi-cluster testing. The shared cluster(s), having better visibility and long-standing setups, are more usable for multiRM testing. Filter out multiRM tests from long-running tests and run any necessary multiRM end-to-end GKE tests in the shared cluster workflow.

Test Plan

CI passes (particularly, long-running workflow passes)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@amandavialva01 amandavialva01 requested a review from a team as a code owner June 13, 2024 16:28
@cla-bot cla-bot bot added the cla-signed label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.92%. Comparing base (05ea5aa) to head (17eaf19).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           wksp-namespace-binding    #9514   +/-   ##
=======================================================
  Coverage                   48.91%   48.92%           
=======================================================
  Files                        1238     1238           
  Lines                      161348   161348           
  Branches                     2783     2783           
=======================================================
+ Hits                        78931    78941   +10     
+ Misses                      82242    82232   -10     
  Partials                      175      175           
Flag Coverage Δ
backend 43.87% <ø> (+0.01%) ⬆️
harness 63.71% <ø> (ø)
web 44.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@amandavialva01 amandavialva01 changed the title chore: refactor shared cluster tests chore: longrunning tests to ignore multiRM marked e2e tests Jun 13, 2024
@amandavialva01 amandavialva01 requested review from a team as code owners June 24, 2024 15:09
@amandavialva01 amandavialva01 requested review from kkunapuli, johnkim-det and jgongd and removed request for a team June 24, 2024 15:09
@amandavialva01 amandavialva01 force-pushed the wksp-namespace-binding branch 5 times, most recently from 5b4fd87 to c71d596 Compare June 25, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants