Add the missing parameter for serialization #7929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
OpenAIGenerator
's to_dict method #7903Proposed Changes:
Add the missing
organization
parameter to the serialization function.How did you test it?
Updated the unit tests to check
organization
parameter during serialization and deserialization.Notes for the reviewer
Though about it , but makes sense to not serialize
timeout
andmax_retries
parameters to allow dynamic configuration as also mentioned in the issue.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.