Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing parameter for serialization #7929

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

Amnah199
Copy link
Contributor

Related Issues

Proposed Changes:

Add the missing organization parameter to the serialization function.

How did you test it?

Updated the unit tests to check organization parameter during serialization and deserialization.

Notes for the reviewer

Though about it , but makes sense to not serialize timeout and max_retries parameters to allow dynamic configuration as also mentioned in the issue.

Checklist

@Amnah199 Amnah199 requested review from a team as code owners June 25, 2024 15:00
@Amnah199 Amnah199 requested review from dfokina and shadeMe and removed request for a team June 25, 2024 15:00
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9664861598

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.968%

Files with Coverage Reduction New Missed Lines %
components/generators/openai.py 2 96.34%
Totals Coverage Status
Change from base Build 9664851641: 0.0%
Covered Lines: 6717
Relevant Lines: 7466

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9665120183

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.968%

Files with Coverage Reduction New Missed Lines %
components/generators/openai.py 2 96.34%
Totals Coverage Status
Change from base Build 9664851641: 0.0%
Covered Lines: 6717
Relevant Lines: 7466

💛 - Coveralls

Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadeMe shadeMe merged commit 866e6c8 into main Jun 26, 2024
17 checks passed
@shadeMe shadeMe deleted the fix-params-openai-generator branch June 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Missing params in OpenAIGenerator's to_dict method
3 participants