Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: chache support to CICD for unit tests #7890

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: chache support to CICD for unit tests #7890

wants to merge 8 commits into from

Conversation

davidberenstein1957
Copy link
Contributor

Related Issues

Proposed Changes:

I though to add cache in a similar way as proposed here: pypa/hatch#669

How did you test it?

N.A.

Notes for the reviewer

I did not test it.

Checklist

@davidberenstein1957 davidberenstein1957 requested review from a team as code owners June 18, 2024 18:55
@davidberenstein1957 davidberenstein1957 requested review from dfokina and shadeMe and removed request for a team June 18, 2024 18:55
@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9570647882

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.872%
Totals Coverage Status
Change from base Build 9568480998: 0.0%
Covered Lines: 6957
Relevant Lines: 7741
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9570669097

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.872%
Totals Coverage Status
Change from base Build 9568480998: 0.0%
Covered Lines: 6957
Relevant Lines: 7741
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9570923716

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.872%
Totals Coverage Status
Change from base Build 9568480998: 0.0%
Covered Lines: 6957
Relevant Lines: 7741
💛 - Coveralls

@masci
Copy link
Contributor

masci commented Jun 19, 2024

Hi @davidberenstein1957

I believe the pip cache path is different across OSes and I'm not sure this will work for, say, Windows (see this build). Can you find a way to make the cache step work across multiple platforms?

@davidberenstein1957
Copy link
Contributor Author

davidberenstein1957 commented Jun 19, 2024 •
edited
Loading

@masci I had noticed, it only works for ubuntu. Will have a look later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@shadeMe shadeMe Awaiting requested review from shadeMe shadeMe is a code owner automatically assigned from deepset-ai/open-source-engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache pip CI/CD pipeline
3 participants
@davidberenstein1957 @coveralls @masci