Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more direct set up data model, tests passing #1193

Merged
merged 27 commits into from
Jun 27, 2024
Merged

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Jun 19, 2024

set up data models like

[
  dedupe.variables.String("name"),
  dedupe.variables.Exact("address")
 ]

instead of

[
  {"field", "name", "type": "String"},
  {"field", "address", "type": "String"},
 ]

supersedes #1122, #1121. will close #1085

Todo:

  • get tests passing
  • update documentation
  • update changelog
  • update external dedupe variables
  • raise helpful message if trying to initialize with a list of dicts
  • update example code

This is is going to be a breaking change, so do we want to make bigger changes like splitting datamodel into feature creators and blocking rules, a la #1102?

@fgregg fgregg marked this pull request as draft June 19, 2024 19:45
@fgregg fgregg force-pushed the different_data_model branch 2 times, most recently from ea86964 to b5dece5 Compare June 21, 2024 13:21
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 85.83333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (f7e131e) to head (954b561).
Report is 5 commits behind head on main.

Current head 954b561 differs from pull request most recent head b74cfdb

Please upload reports for the commit b74cfdb to get more accurate results.

Files Patch % Lines
dedupe/variables/base.py 80.00% 5 Missing ⚠️
dedupe/variables/set.py 33.33% 4 Missing ⚠️
dedupe/variables/string.py 66.66% 4 Missing ⚠️
dedupe/datamodel.py 94.11% 2 Missing ⚠️
dedupe/variables/exists.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   73.57%   74.24%   +0.67%     
==========================================
  Files          29       29              
  Lines        2293     2221      -72     
==========================================
- Hits         1687     1649      -38     
+ Misses        606      572      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgregg
Copy link
Contributor Author

fgregg commented Jun 21, 2024

I still think @NickCrews's ideas about breaking apart the DataModel object is good, but i think that we should be able to do that in a way that does not break backwards compatibility, so I think we don't need to try to bring it in now.

@fgregg fgregg marked this pull request as ready for review June 26, 2024 20:47
@fgregg fgregg merged commit 8855842 into main Jun 27, 2024
35 of 36 checks passed
@NickCrews
Copy link
Contributor

@fgregg dedupe returns from the dead! 😉 Great to see some love happening here, thanks for your work!

fgregg added a commit that referenced this pull request Jun 27, 2024
fgregg added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transition to plugins for dedupe variables.
2 participants