Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if timestamp updated_at field uses incompatible timestamp #10352

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jun 21, 2024

resolves #10234

Problem

Snapshot tables use the 'get_snapshot_time' macro, which may be incompatible with the data type of the field specified as the 'updated_at' field, causing unexpected results.

Solution

Warn if the two sources of timestamp columns have different data types.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank requested a review from a team as a code owner June 21, 2024 20:46
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (ca163c3) to head (871052c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10352      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.02%     
==========================================
  Files         180      180              
  Lines       22486    22497      +11     
==========================================
+ Hits        19958    19964       +6     
- Misses       2528     2533       +5     
Flag Coverage Δ
integration 86.00% <100.00%> (-0.02%) ⬇️
unit 62.19% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

time: 2024-06-21T16:44:00.023992-04:00
custom:
Author: gshank
Issue: "10234"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: are two changelog entries intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if updated_at field for snapshot is not same datatype as what's returned in snapshot_get_time()
2 participants